Skip to content

latest tag being bind to the wrong Docker image #25193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WarningImHack3r opened this issue Jun 10, 2023 · 11 comments · Fixed by #25471
Closed

latest tag being bind to the wrong Docker image #25193

WarningImHack3r opened this issue Jun 10, 2023 · 11 comments · Fixed by #25471
Labels

Comments

@WarningImHack3r
Copy link

WarningImHack3r commented Jun 10, 2023

Description

The latest tag of your Docker image is often bind to the wrong Gitea version. I often notice that it's bind to some RC version, dev version, or currently to the 1.21.0-dev version, which is definitely not good.

I notice it because I'm running Watchtower daily to always keep my containers up-to-date, and right now my Gitea container has been bumped to this dev version and is no longer working because of an undocumented breaking change.

I can also think about the people attempting to casually download and run Gitea for the first time with a simple gitea/gitea and won't understand why it's not working.

So can you please make sure the :latest tag always points to the latest stable version please?

Gitea Version

1.21.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

latest

1 21 0

Git Version

No response

Operating System

Raspberry Pi OS 64bit

How are you running Gitea?

:latest Docker image

Database

SQLite

@lakoliu
Copy link

lakoliu commented Jun 10, 2023

I came hear wondering if anyone else's Gitea wasn't working. This must be the reason. My container seems to be continuously trying to restart right now.

@WarningImHack3r
Copy link
Author

@lakoliu it's even more a pain that we not only have to manually downgrade but we also have to tweak/disable Watchtower temporarily because it's will bump Gitea again during its next run...

@delvh
Copy link
Member

delvh commented Jun 10, 2023

Yes, we know.
We've noticed this bug immediately when releasing 1.20.0-rc0 as the new container was pushed almost immediately from our CI.
However, we couldn't downgrade anymore without causing breakages.

@WarningImHack3r
Copy link
Author

@delvh I see. I assume it could only be fixed releasing a new version (1.19.x/1.20) ? Or is it even worse: not being able to fix it until a stable 1.21.0 version?

Have you planned some changes to not make it happen again? It's not the first time :latest is bind to an non-stable version

@wxiaoguang
Copy link
Contributor

I came hear wondering if anyone else's Gitea wasn't working. This must be the reason. My container seems to be continuously trying to restart right now.

Are you using 1.20? 1.20 has some breaking changes, could you share your logs?

@delvh
Copy link
Member

delvh commented Jun 10, 2023

I assume it could only be fixed releasing a new version (1.19.x/1.20)

No, as your db will be upgraded with new versions.
You mean a stable 1.20 version, 1.21.0-dev simply means here stopped the development on 1.20 and started the development on 1.21.

@WarningImHack3r
Copy link
Author

@delvh so if I get it correctly it won't be fixed until 1.20.0 stable is released?

@delvh
Copy link
Member

delvh commented Jun 10, 2023

Yep

@WarningImHack3r
Copy link
Author

Have you planned some changes to not make it happen again? It's not the first time :latest is bind to an non-stable version

Ok, and about that @delvh?

@delvh
Copy link
Member

delvh commented Jun 10, 2023

Well… We'll try to harden our CI not to set the latest tag anymore on -dev tags, but that is a trial and error process:
The only way to know it works is by releasing something, so we can only hope it won't occur next time again.

@WarningImHack3r
Copy link
Author

Don't forget -nightly, -rc* and others! 😄 Thanks for your quick response

delvh added a commit that referenced this issue Jun 23, 2023
Try to prevent what happened with tag `v1.21.0-dev` as outlined in
#25193.
Unfortunately, we cannot really test if it works as intended as we would
need to release a new `dev` tag for that.
Fixes #25193 (or at least attempts to).

---------

Co-authored-by: jolheiser <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants