API /repos/{owner}/{repo}/commits call error 500 on non-existent branch

[AdamMajer]

Description

No response

Gitea Version

1.23.0+dev-460-ga366af4b7a (or 1.22)

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

This works,

curl -X 'GET' \
  'https://demo.gitea.com/api/v1/repos/bartvdbraak/blender/commits?sha=before-big-change&stat=false&verification=false&files=false&page=1' \
  -H 'accept: application/json'

but changing the sha= parameter to invalid one (eg. a branch that doesn't exist)

curl -X 'GET' \
  'https://demo.gitea.com/api/v1/repos/bartvdbraak/blender/commits?sha=not-before-big-change&stat=false&verification=false&files=false&page=1' \
  -H 'accept: application/json'

results in error 500. Expectation is we get an empty result set with result code of 200 if repository exists but branch/commit id does not.

Database

None

[AdamMajer]

So, looks like any error in the sources results in error 500. Is this just temporary result at the time until a better one can be found?

204 No Content

is probably also applicable here, if no commits are found.

[AdamMajer]

404 doesn't seem to match this error condition either since that is returned when repository is not there, not just a branch.