Skip to content

CODEOWNERS trigger on PR update also activated by merge commit #34224

Closed
@splitt3r

Description

@splitt3r

Description

The recent change in behaviour introduced in #33744 / reported by #33490 is also triggered by files which are changed in a merge commit (update branch button in the PR) but not really touched by the code changes in the PR. This leads to quite some mail / reviewer spam in our environment.

Steps to reproduce:

  • Create CODEOWNERS file for test.txt on main
  • Create PR which changes a file (not test.txt)
  • Change test.txt on main branch
  • Update PR branch via Gitea UI
  • Now the CODEOWNERS for test.txt will be assigned even if the PR does not change text.txt

Gitea Version

1.23.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Ubuntu installation

Database

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions