Fix CSV render error (#17406) #17431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closed go-gitea#17378 Both errors from go-gitea#17378 were caused by go-gitea#15175. Problem 1 (error with added file): `ToUTF8WithFallbackReader` creates a `MultiReader` from a `byte[2048]` and the remaining reader. `CreateReaderAndGuessDelimiter` tries to read 10000 bytes from this reader but only gets 2048 because that's the first reader in the `MultiReader`. Then the `if size < 1e4` thinks the input is at EOF and just returns that. Problem 2 (error with changed file): The blob reader gets defer closed. That was fine because the old version reads the whole file into memory. Now with the streaming version the close needs to defer after the method.
6543
changed the title
6543
approved these changes
Oct 25, 2021
GiteaBot
added
the
lgtm/need 1
richmahn
approved these changes
Oct 25, 2021
GiteaBot
added
lgtm/done
lafriks
approved these changes
Oct 25, 2021
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 27, 2021
Unforunately go-gitea#17435 is a somewhat critical bug and therefore we should really release 1.15.6 as soon as possible. ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-27 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435) * Fix CSV render error (go-gitea#17406) (go-gitea#17431) * Read expected buffer size (go-gitea#17409) (go-gitea#17430) Signed-off-by: Andrew Thornton <[email protected]>
Merged
lunny
pushed a commit
that referenced
this pull request
Oct 28, 2021
* Changelog 1.15.6 Unforunately #17435 is a somewhat critical bug and therefore we should really release 1.15.6 as soon as possible. ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-27 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (#17434) (#17435) * Fix CSV render error (#17406) (#17431) * Read expected buffer size (#17409) (#17430) Signed-off-by: Andrew Thornton <[email protected]> * Add 17456 and its backport Signed-off-by: Andrew Thornton <[email protected]> * Add 17464 Signed-off-by: Andrew Thornton <[email protected]> * Add final pr * Update date Co-authored-by: wxiaoguang <[email protected]>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 28, 2021
Frontport go-gitea#17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435) * Fix CSV render error (go-gitea#17406) (go-gitea#17431) * Read expected buffer size (go-gitea#17409) (go-gitea#17430) * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464) * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
zeripath
added a commit
that referenced
this pull request
Oct 28, 2021
Frontport #17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (#17434) (#17435) * Fix CSV render error (#17406) (#17431) * Read expected buffer size (#17409) (#17430) * Ensure that restricted users can access repos for which they are members (#17460) (#17464) * Make commit-statuses popup show correctly (#17447) (#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (#17456) (#17463)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Frontport go-gitea#17457 ## [1.15.6](https://github.com/go-gitea/gitea/releases/tag/v1.15.6) - 2021-10-28 * BUGFIXES * Prevent panic in serv.go with Deploy Keys (go-gitea#17434) (go-gitea#17435) * Fix CSV render error (go-gitea#17406) (go-gitea#17431) * Read expected buffer size (go-gitea#17409) (go-gitea#17430) * Ensure that restricted users can access repos for which they are members (go-gitea#17460) (go-gitea#17464) * Make commit-statuses popup show correctly (go-gitea#17447) (go-gitea#17466) * TESTING * Add integration tests for private.NoServCommand and private.ServCommand (go-gitea#17456) (go-gitea#17463)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17406.