Pin Repositories on user page (Fixes #10375)

models/repo/repo.go

@@ -217,6 +217,20 @@ func (repo *Repository) IsBroken() bool {
 	return repo.Status == RepositoryBroken
 }
 
+// IsPinned indicates that repository is pinned
+func (repo *Repository) IsPinned() bool {
+	pinned, err := user_model.GetPinnedRepositoryIDs(repo.OwnerID)
+	if err != nil {
+		return false
+	}
+	for _, r := range pinned {
+		if r == repo.ID {
+			return true
+		}
+	}
+	return false
+}
+
 // AfterLoad is invoked from XORM after setting the values of all fields of this object.
 func (repo *Repository) AfterLoad() {
 	// FIXME: use models migration to solve all at once.

models/user/pin.go

@@ -0,0 +1,106 @@
+// Copyright 2022 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package user
+
+import (
+	"fmt"
+
+	"code.gitea.io/gitea/modules/json"
+)
+
+const maxPinnedRepos = 3
+
+// Get all the repositories pinned by a user. If they've never
+// set pinned repositories, an empty array is returned.
+func GetPinnedRepositoryIDs(userID int64) ([]int64, error) {
+	pinnedstring, err := GetUserSetting(userID, PinnedRepositories)
+	if err != nil {
+		return nil, err
+	}
+
+	var parsedValues []int64
+	if pinnedstring == "" {
+		return parsedValues, nil
+	}
+
+	err = json.Unmarshal([]byte(pinnedstring), &parsedValues)
+
+	if err != nil {
+		return nil, err
+	}
+
+	return parsedValues, nil
+}
+
+func setPinnedRepositories(userID int64, repos []int64) error {
+	stringed, err := json.Marshal(repos)
+	if err != nil {
+		return err
+	}
+
+	return SetUserSetting(userID, PinnedRepositories, string(stringed))
+}
+
+type TooManyPinnedReposError struct {
+	count int
+}
+
+func (e *TooManyPinnedReposError) Error() string {
+	return fmt.Sprintf("can pin at most %d repositories, %d pinned repositories is too much", maxPinnedRepos, e.count)
+}
+
+// Add some repos to a user's pinned repositories.
+// The caller must ensure all repos belong to the
+// owner.
+func PinRepos(ownerID int64, repoIDs ...int64) error {
+	repos, err := GetPinnedRepositoryIDs(ownerID)
+	if err != nil {
+		return err
+	}
+	newrepos := make([]int64, 0, len(repoIDs)+len(repos))
+
+	repos = append(repos, repoIDs...)
+
+	for _, toadd := range repos {
+		alreadypresent := false
+		for _, present := range newrepos {
+			if toadd == present {
+				alreadypresent = true
+				break
+			}
+		}
+		if !alreadypresent {
+			newrepos = append(newrepos, toadd)
+		}
+	}
+	if len(newrepos) > maxPinnedRepos {
+		return &TooManyPinnedReposError{count: len(newrepos)}
+	}
+	return setPinnedRepositories(ownerID, newrepos)
+}
+
+// Remove some repos from a user's pinned repositories.
+func UnpinRepos(ownerID int64, repoIDs ...int64) error {
+	prevRepos, err := GetPinnedRepositoryIDs(ownerID)
+	if err != nil {
+		return err
+	}
+	var nextRepos []int64
+
+	for _, r := range prevRepos {
+		keep := true
+		for _, unp := range repoIDs {
+			if r == unp {
+				keep = false
+				break
+			}
+		}
+		if keep {
+			nextRepos = append(nextRepos, r)
+		}
+	}
+
+	return setPinnedRepositories(ownerID, nextRepos)
+}

models/user/pin_test.go

@@ -0,0 +1,38 @@
+// Copyright 2022 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package user
+
+import (
+	"testing"
+
+	"code.gitea.io/gitea/models/unittest"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestUserPinUnpinRepos(t *testing.T) {
+	assert.NoError(t, unittest.PrepareTestDatabase())
+	// User:2 pins repositories 1 and 2
+	{
+		assert.NoError(t, PinRepos(2, 1, 2))
+		pinned, err := GetPinnedRepositoryIDs(2)
+
+		if assert.NoError(t, err) {
+			expected := []int64{1, 2}
+			assert.Equal(t, pinned, expected)
+		}
+	}
+	// User:2 unpins repository 2, leaving just 1
+	{
+		assert.NoError(t, UnpinRepos(2, 1))
+
+		pinned, err := GetPinnedRepositoryIDs(2)
+
+		if assert.NoError(t, err) {
+			expected := []int64{2}
+			assert.Equal(t, pinned, expected)
+		}
+	}
+}

models/user/setting_keys.go

@@ -9,4 +9,5 @@ const (
 	SettingsKeyHiddenCommentTypes = "issue.hidden_comment_types"
 	// SettingsKeyDiffWhitespaceBehavior is the setting key for whitespace behavior of diff
 	SettingsKeyDiffWhitespaceBehavior = "diff.whitespace_behaviour"
+	PinnedRepositories                = "pinned_repos"
 )

routers/web/org/home.go

@@ -10,9 +10,12 @@ import (
 
 	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/models/organization"
+	access "code.gitea.io/gitea/models/perm/access"
 	repo_model "code.gitea.io/gitea/models/repo"
+	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/base"
 	"code.gitea.io/gitea/modules/context"
+	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/markup"
 	"code.gitea.io/gitea/modules/markup/markdown"
 	"code.gitea.io/gitea/modules/setting"
@@ -149,8 +152,41 @@ func Home(ctx *context.Context) {
 		return
 	}
 
+	pinnedRepoIDs, err := user_model.GetPinnedRepositoryIDs(org.ID)
+	if err != nil {
+		ctx.ServerError("GetPinnedRepositoryIDs", err)
+		return
+	}
+	pinnedRepos := make([]*repo_model.Repository, 0, len(pinnedRepoIDs))
+	for _, id := range pinnedRepoIDs {
+		repo, err := repo_model.GetRepositoryByID(id)
+		if err != nil {
+			ctx.ServerError("GetRepositoryByID", err)
+			return
+		}
+		if err = repo.LoadAttributes(ctx); err != nil {
+			ctx.ServerError("LoadAttributes", err)
+			return
+		}
+		if repo.OwnerID != org.ID {
+			log.Warn("Ignoring pinned repo %v because it's not owned by %v", repo.FullName(), org.Name)
+		} else {
+			perm, err := access.GetUserRepoPermission(ctx, repo, ctx.Doer)
+			if err != nil {
+				ctx.ServerError("GetUserRepoPermission", err)
+				return
+			}
+			if !perm.HasAccess() {
+				log.Info("Ignoring pinned repo %v because user %v has no access to it.", repo.FullName(), ctx.Doer)
+			} else {
+				pinnedRepos = append(pinnedRepos, repo)
+			}
+		}
+	}
+
 	ctx.Data["Owner"] = org
 	ctx.Data["Repos"] = repos
+	ctx.Data["PinnedRepos"] = pinnedRepos
 	ctx.Data["Total"] = count
 	ctx.Data["MembersTotal"] = membersCount
 	ctx.Data["Members"] = members

routers/web/repo/pin_test.go

@@ -0,0 +1,121 @@
+// Copyright 2022 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package repo
+
+import (
+	"testing"
+
+	"code.gitea.io/gitea/models/unittest"
+	"code.gitea.io/gitea/modules/test"
+
+	"github.com/stretchr/testify/assert"
+)
+
+const (
+	pin   = true
+	unpin = false
+)
+
+func TestUserPinUnpin(t *testing.T) {
+	unittest.PrepareTestEnv(t)
+	// These test cases run sequentially since they modify state
+	testcases := []struct {
+		uid          int64
+		rid          int64
+		action       bool
+		endstate     bool
+		failmesssage string
+	}{
+		{
+			uid:          2,
+			rid:          2,
+			action:       pin,
+			endstate:     pin,
+			failmesssage: "user cannot pin repos they own",
+		},
+		{
+			uid:          2,
+			rid:          2,
+			action:       unpin,
+			endstate:     unpin,
+			failmesssage: "user cannot unpin repos they own",
+		},
+
+		{
+			uid:          2,
+			rid:          5,
+			action:       pin,
+			endstate:     pin,
+			failmesssage: "user cannot pin repos they have admin access to",
+		},
+		{
+			uid:          2,
+			rid:          5,
+			action:       unpin,
+			endstate:     unpin,
+			failmesssage: "user cannot unpin repos they have admin access to",
+		},
+
+		{
+			uid:          2,
+			rid:          4,
+			action:       pin,
+			endstate:     unpin,
+			failmesssage: "user can pin repos they don't have access to",
+		},
+
+		{
+			uid:          5,
+			rid:          4,
+			action:       pin,
+			endstate:     pin,
+			failmesssage: "user cannot pin repos they own (this should never fail)",
+		},
+		{
+			uid:          2,
+			rid:          4,
+			action:       unpin,
+			endstate:     pin,
+			failmesssage: "user can unpin repos they don't have access to",
+		},
+		{
+			uid:          1,
+			rid:          4,
+			action:       unpin,
+			endstate:     unpin,
+			failmesssage: "admin can't unpin repos they don't have access to",
+		},
+		{
+			uid:          1,
+			rid:          4,
+			action:       pin,
+			endstate:     pin,
+			failmesssage: "admin can't pin repos they don't have access to",
+		},
+	}
+
+	for _, c := range testcases {
+		ctx := test.MockContext(t, "")
+		test.LoadUser(t, ctx, c.uid)
+		test.LoadRepo(t, ctx, c.rid)
+
+		switch c.action {
+		case pin:
+			ctx.SetParams(":action", "pin")
+		case unpin:
+			ctx.SetParams(":action", "unpin")
+		}
+
+		Action(ctx)
+		ispinned := getRepository(ctx, c.rid).IsPinned()
+
+		assert.Equal(t, ispinned, c.endstate, c.failmesssage)
+
+		if c.endstate != ispinned {
+			// We have to stop at first failure, state won't be coherent afterwards.
+			return
+		}
+	}
+}

routers/web/repo/repo.go

@@ -32,6 +32,7 @@ import (
 	"code.gitea.io/gitea/services/forms"
 	repo_service "code.gitea.io/gitea/services/repository"
 	archiver_service "code.gitea.io/gitea/services/repository/archiver"
+	user_service "code.gitea.io/gitea/services/user"
 )
 
 const (
@@ -292,6 +293,22 @@ func Action(ctx *context.Context) {
 		err = repo_model.StarRepo(ctx.Doer.ID, ctx.Repo.Repository.ID, true)
 	case "unstar":
 		err = repo_model.StarRepo(ctx.Doer.ID, ctx.Repo.Repository.ID, false)
+	case "pin":
+		if user_service.CanPin(ctx, ctx.Doer, ctx.Repo.Repository) {
+			err = user_model.PinRepos(ctx.Repo.Owner.ID, ctx.Repo.Repository.ID)
+			if _, ok := err.(*user_model.TooManyPinnedReposError); ok {
+				ctx.Error(http.StatusBadRequest, err.Error())
+				return
+			}
+		} else {
+			err = errors.New("user does not have permission to pin")
+		}
+	case "unpin":
+		if user_service.CanPin(ctx, ctx.Doer, ctx.Repo.Repository) {
+			err = user_model.UnpinRepos(ctx.Repo.Owner.ID, ctx.Repo.Repository.ID)
+		} else {
+			err = errors.New("user does not have permission to unpin")
+		}
 	case "accept_transfer":
 		err = acceptOrRejectRepoTransfer(ctx, true)
 	case "reject_transfer":

routers/web/repo/view.go

@@ -41,6 +41,7 @@ import (
 	"code.gitea.io/gitea/modules/typesniffer"
 	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/routers/web/feed"
+	user_service "code.gitea.io/gitea/services/user"
 )
 
 const (
@@ -733,6 +734,7 @@ func Home(ctx *context.Context) {
 	}
 
 	ctx.Data["FeedURL"] = ctx.Repo.Repository.HTMLURL()
+	ctx.Data["CanPin"] = ctx.IsSigned && user_service.CanPin(ctx, ctx.Doer, ctx.Repo.Repository)
 
 	checkHomeCodeViewable(ctx)
 	if ctx.Written() {