-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Switch to ansi_up for ansi rendering in actions #25401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But apart from that LGTM
@wxiaoguang can you help me update these tests? They talk about some bugs in AnsiToHTML but those seem not present in |
Tests are now passing, but I'm not 100% certain the results are as expected. There are a number of |
Ready again. I've moved the function and tests to separate files and restored all previous tests. The only test modification I did was to replace the previous ansi_to_html tests with test cases that call the function. The problem with the The seemingly odd |
Fixes: #24777