Start using template context function #26254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
type/refactoring
wxiaoguang
force-pushed
the
use-context-func
branch
3 times, most recently
from
efe7049 to
81cc43c
Compare
wxiaoguang
force-pushed
the
use-context-func
branch
from
81cc43c to
db19c18
Compare
|
CI passes and ready for review |
lunny
approved these changes
Aug 2, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Aug 8, 2023
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 8, 2023
* upstream/main: Start using template context function (go-gitea#26254) Allow package cleanup from admin page (go-gitea#25307) Fix text truncate (go-gitea#26354) Fix incorrect sort link with `.profile` repository (go-gitea#26374) Use more `IssueList` instead of `[]*Issue` (go-gitea#26369) Rename code_langauge.go to code_language.go (go-gitea#26377) Add changelog for 1.20.3 (go-gitea#26373) Do not highlight `#number` in documents (go-gitea#26365) Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (go-gitea#26279) Fix nil pointer dereference error when open link with invalid pull index (go-gitea#26353)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
{{.locale.Tr ...}}{{$.locale.Tr ...}}{{$.root.locale.Tr ...}}{{template "sub" .}}{{template "sub" (dict "locale" $.locale)}}{{template "sub" (dict "root" $)}}With context function: only need to
{{ctx.Locale.Tr ...}}The "ctx" could be considered as a super-global variable for all templates including sub-templates.
To avoid potential risks (any bug in the template context function package), this PR only starts using "ctx" in "head.tmpl" and "footer.tmpl" and it has a "DataRaceCheck". If there is anything wrong, the code can be fixed or reverted easily.