More fixes for the "commit-body" #26898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
topic/ui
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Sep 4, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Sep 4, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 5, 2023
* giteaofficial/main: Move mail notification logic to service layer (go-gitea#26905) Improve DeleteByID (go-gitea#26904) Update backup instructions to align with archive structure (go-gitea#26902) More fixes for the "commit-body" (go-gitea#26898) Show queue's active worker number (go-gitea#26896) Remove CSS `has` selector and improve various styles (go-gitea#26891)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes for "commit-body" in #26877 are not ideal.
The reason is: the "commit-body" is usually a
<pre>, it has default margins. In most cases, we do not need that large margin. So, this PR introduces a general but small margin for all "commit-body" elements. Then thesegt-m-0could be removed.The
:notselector is not needed, because the.timeline-itemselector is already clear enough.