Skip to content

Do some missing checks #28423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 12, 2023
+62 −3
Merged

Do some missing checks #28423

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
196fcc1
private user's projects need permission check
lunny Oct 15, 2023
d03d822
Fix test
lunny Dec 11, 2023
53bb6ab
Use a function to do the permission checker
lunny Dec 11, 2023
658e605
Check private user's code router
lunny Dec 11, 2023
37b6490
Add limit permission check
lunny Dec 11, 2023
c340e87
Fix private user visit via APi
lunny Dec 11, 2023
4bd6a96
Fix test
lunny Dec 11, 2023
a79bbf9
Fix test
lunny Dec 12, 2023
13dbe4d
Merge branch 'main' into lunny/fix_private_user_project
lunny Dec 12, 2023
4e7df1d
Fix middleware
lunny Dec 12, 2023
3bae798
Fix test
lunny Dec 12, 2023
221bcde
Remove unnecessary change
lunny Dec 12, 2023
011ef5e
Fix function parameter
lunny Dec 12, 2023
b0c36ce
Merge branch 'main' into lunny/fix_private_user_project
lunny Dec 12, 2023
426903d
Fix bug
lunny Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix bug
  • Loading branch information
@lunny
lunny committed Dec 12, 2023
commit 426903d41d6fe8c08c339ac0ea7936c2a3df7b23
21 changes: 10 additions & 11 deletions tests/integration/api_packages_nuget_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,16 @@ func TestPackageNuGet(t *testing.T) {
privateUser := unittest.AssertExistsAndLoadBean(t, &user_model.User{Visibility: structs.VisibleTypePrivate})

cases := []struct {
Owner string
UseBasicAuth bool
UseTokenAuth bool
ExpectedStatus int
Owner string
UseBasicAuth bool
UseTokenAuth bool
}{
{privateUser.Name, false, false, http.StatusNotFound},
{privateUser.Name, true, false, http.StatusOK},
{privateUser.Name, false, true, http.StatusOK},
{user.Name, false, false, http.StatusOK},
{user.Name, true, false, http.StatusOK},
{user.Name, false, true, http.StatusOK},
{privateUser.Name, false, false},
{privateUser.Name, true, false},
{privateUser.Name, false, true},
{user.Name, false, false},
{user.Name, true, false},
{user.Name, false, true},
}

for _, c := range cases {
Expand All @@ -146,7 +145,7 @@ func TestPackageNuGet(t *testing.T) {
} else if c.UseTokenAuth {
req = addNuGetAPIKeyHeader(req, token)
}
resp := MakeRequest(t, req, c.ExpectedStatus)
resp := MakeRequest(t, req, http.StatusOK)

var result nuget.ServiceIndexResponseV2
decodeXML(t, resp, &result)
Expand Down