-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: Elasticsearch: Request Entity Too Large #28117 #29062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix for gitea putting everything into one request and send it to elasticsearch as issued in #28117
This batch length is for queue but no for elastic search. |
I've 2 points to mention here:
|
Thank your for your PR! (It is really fast 👍) Two suggestions in my mind:
|
Thanks a lot @lunny @wxiaoguang for clearing me out. |
Ideally Gitea should also read the contents into batches (but not read everything into As a quick fix, this PR is better than before. |
…#29062) Fix for gitea putting everything into one request without batching and sending it to Elasticsearch for indexing as issued in go-gitea#28117 This issue occured in large repositories while Gitea tries to index the code using ElasticSearch. I've applied necessary changes that takes batch length from below config (app.ini) ``` [queue.code_indexer] BATCH_LENGTH=<length_int> ``` and batches all requests to Elasticsearch in chunks as configured in the above config
@lunny the commit message is wrong (again). Please manually fix the PR description before merging. |
Backport #29062 by @inferno-umar Fix for gitea putting everything into one request without batching and sending it to Elasticsearch for indexing as issued in #28117 This issue occured in large repositories while Gitea tries to index the code using ElasticSearch. Co-authored-by: dark-angel <[email protected]>
…#29062) Fix for gitea putting everything into one request without batching and sending it to Elasticsearch for indexing as issued in go-gitea#28117 This issue occured in large repositories while Gitea tries to index the code using ElasticSearch. I've applied necessary changes that takes batch length from below config (app.ini) ``` [queue.code_indexer] BATCH_LENGTH=<length_int> ``` and batches all requests to Elasticsearch in chunks as configured in the above config
…o-gitea#29062) Fix for gitea putting everything into one request without batching and sending it to Elasticsearch for indexing as issued in go-gitea#28117 This issue occured in large repositories while Gitea tries to index the code using ElasticSearch. I've applied necessary changes that takes batch length from below config (app.ini) ``` [queue.code_indexer] BATCH_LENGTH=<length_int> ``` and batches all requests to Elasticsearch in chunks as configured in the above config (cherry picked from commit 5c0fc90)
Fix for gitea putting everything into one request without batching and sending it to Elasticsearch for indexing as issued in #28117
This issue occured in large repositories while Gitea tries to
index the code using ElasticSearch.
I've applied necessary changes that takes batch length from below config (app.ini)
and batches all requests to Elasticsearch in chunks as configured in the above config