Skip to content

Refactor repo-projects.ts #32892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 19, 2024
Merged

Refactor repo-projects.ts #32892

merged 14 commits into from
Dec 19, 2024

Conversation

silverwind
Copy link
Member

  • Remove jQuery
  • Add types to all functions
  • Tested all modified functionality

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2024
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 18, 2024
wxiaoguang
wxiaoguang reviewed Dec 19, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 19, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 19, 2024
View reviewed changes
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2024
wxiaoguang
wxiaoguang previously requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a request change to avoid accident merge, feel free to dismiss it if the reviews above are resolved.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 19, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 19, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 19, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 19, 2024
@wxiaoguang
Copy link
Contributor

Found various legacy problems and bugs, fixed together

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Dec 19, 2024
@silverwind
Copy link
Member Author

Some more minor js tweaks done. I renamed to SortableType because I think it's bad to have a type and variable of the same name in the same file. It did work in this case for some reason, but I think we better avoid it.

wxiaoguang
wxiaoguang reviewed Dec 19, 2024
View reviewed changes
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2024
@silverwind silverwind enabled auto-merge (squash) December 19, 2024 08:12
@silverwind silverwind merged commit 141d782 into go-gitea:main Dec 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 19, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @wxiaoguang @lunny @delvh @GiteaBot