Skip to content

demilestone should not include milestone #32923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2024
Merged

demilestone should not include milestone #32923

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d53bf33
demilestone should not include milestone
lunny Dec 20, 2024
cdd47c7
add test for change milestone
lunny Dec 25, 2024
90b24e8
Merge branch 'main' into lunny/fix_demilestoned_webhook
lunny Dec 25, 2024
9181fd2
Fix test
lunny Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test
  • Loading branch information
@lunny
lunny committed Dec 25, 2024
commit 9181fd27b0393f32f5d24e2a777a14707c67cc56
1 change: 1 addition & 0 deletions services/issue/milestone_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ func TestChangeMilestoneAssign(t *testing.T) {
unittest.CheckConsistencyFor(t, &issues_model.Milestone{}, &issues_model.Issue{})
assert.NotNil(t, issue.Milestone)

oldMilestoneID = issue.MilestoneID
issue.MilestoneID = 0
assert.NoError(t, ChangeMilestoneAssign(db.DefaultContext, issue, doer, oldMilestoneID))
assert.EqualValues(t, 0, issue.MilestoneID)
Expand Down
Loading