Skip to content

Refactor db package and remove unnecessary DumpTables #32930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Refactor db package and remove unnecessary DumpTables #32930

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e86207
fix
wxiaoguang Dec 20, 2024
c4feea8
rename
wxiaoguang Dec 20, 2024
aa90700
Merge branch 'main' into refactor-db
wxiaoguang Dec 20, 2024
8d61a20
Update models/db/engine_dump.go
wxiaoguang Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update models/db/engine_dump.go 
Co-authored-by: delvh <[email protected]>
  • Loading branch information
@wxiaoguang @delvh
wxiaoguang and delvh authored Dec 20, 2024
commit 8d61a20d9d53678f77380570c74aa6f14bb186fa
2 changes: 1 addition & 1 deletion models/db/engine_dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func DumpDatabase(filePath, dbType string) error {
}
tbs = append(tbs, t)

if len(dbType) > 0 {
if dbType != "" {
return xormEngine.DumpTablesToFile(tbs, filePath, schemas.DBType(dbType))
}
return xormEngine.DumpTablesToFile(tbs, filePath)
Expand Down
Loading