Skip to content

Refactor legacy JS #33115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Refactor legacy JS #33115

merged 2 commits into from
Jan 6, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 6, 2025

4 JS files with "import jquery" left.

Tested all related pages.

Notification: manually tested, it should be right IMO.

Team Permission:

image

Team repo search:

image

Issue branch:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 6, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 6, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 6, 2025
@wxiaoguang wxiaoguang merged commit ef736b7 into go-gitea:main Jan 6, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-js branch January 6, 2025 09:38
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 6, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 7, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Remove extended glob pattern from branch protection UI (go-gitea#33125)
  fix empty repo updated time (go-gitea#33120)
  Refactor package (routes and error handling, npm peer dependency) (go-gitea#33111)
  Refactor legacy JS (go-gitea#33115)
  Fix repo empty guide (go-gitea#33114)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants