-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add API to support link package to repository and unlink it #33481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1697d2b
Add API to support link package to repository and unlink it
lunny 7e8fa1e
Fix swagger
lunny 4d3a964
Fix swagger
lunny 1268520
Apply suggestions from code review
lunny 023197c
Fix bugs
lunny 0f0c0be
Merge branch 'main' into lunny/link_package
lunny 5115dfc
improve the error string
lunny 5a3b518
Merge branch 'main' into lunny/link_package
GiteaBot a92b169
Merge branch 'main' into lunny/link_package
GiteaBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
// Copyright 2025 The Gitea Authors. All rights reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
package packages | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
|
||
org_model "code.gitea.io/gitea/models/organization" | ||
packages_model "code.gitea.io/gitea/models/packages" | ||
access_model "code.gitea.io/gitea/models/perm/access" | ||
repo_model "code.gitea.io/gitea/models/repo" | ||
"code.gitea.io/gitea/models/unit" | ||
user_model "code.gitea.io/gitea/models/user" | ||
"code.gitea.io/gitea/modules/util" | ||
) | ||
|
||
func LinkToRepository(ctx context.Context, pkg *packages_model.Package, repo *repo_model.Repository, doer *user_model.User) error { | ||
if pkg.OwnerID != repo.OwnerID { | ||
return util.ErrPermissionDenied | ||
} | ||
if pkg.RepoID > 0 { | ||
return util.ErrInvalidArgument | ||
} | ||
|
||
perms, err := access_model.GetUserRepoPermission(ctx, repo, doer) | ||
if err != nil { | ||
return fmt.Errorf("error getting permissions for user %d on repository %d: %w", doer.ID, repo.ID, err) | ||
} | ||
if !perms.CanWrite(unit.TypePackages) { | ||
lunny marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return util.ErrPermissionDenied | ||
} | ||
|
||
if err := packages_model.SetRepositoryLink(ctx, pkg.ID, repo.ID); err != nil { | ||
return fmt.Errorf("error while linking package '%v' to repo '%v' : %w", pkg.Name, repo.FullName(), err) | ||
} | ||
return nil | ||
} | ||
|
||
func UnlinkFromRepository(ctx context.Context, pkg *packages_model.Package, doer *user_model.User) error { | ||
if pkg.RepoID == 0 { | ||
return util.ErrInvalidArgument | ||
} | ||
|
||
repo, err := repo_model.GetRepositoryByID(ctx, pkg.RepoID) | ||
if err != nil { | ||
return fmt.Errorf("error getting repository %d: %w", pkg.RepoID, err) | ||
} | ||
|
||
perms, err := access_model.GetUserRepoPermission(ctx, repo, doer) | ||
if err != nil { | ||
return fmt.Errorf("error getting permissions for user %d on repository %d: %w", doer.ID, repo.ID, err) | ||
} | ||
if !perms.CanWrite(unit.TypePackages) { | ||
return util.ErrPermissionDenied | ||
} | ||
|
||
user, err := user_model.GetUserByID(ctx, pkg.OwnerID) | ||
if err != nil { | ||
return err | ||
} | ||
if !doer.IsAdmin { | ||
if !user.IsOrganization() { | ||
if doer.ID != pkg.OwnerID { | ||
return fmt.Errorf("no permission to unlink package '%v' from its repository, or packages are disabled", pkg.Name) | ||
} | ||
} else { | ||
isOrgAdmin, err := org_model.OrgFromUser(user).IsOrgAdmin(ctx, doer.ID) | ||
if err != nil { | ||
return err | ||
} else if !isOrgAdmin { | ||
return fmt.Errorf("no permission to unlink package '%v' from its repository, or packages are disabled", pkg.Name) | ||
} | ||
} | ||
} | ||
return packages_model.UnlinkRepository(ctx, pkg.ID) | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.