Skip to content

Refactor admin/common.ts #33788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

wxiaoguang
Copy link
Contributor

Only remove jQuery

Legacy code is still quite unclear, but I don't have time to do a full rewritting, so keep it as-is at the moment.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@wxiaoguang
Copy link
Contributor Author

Diff by ignoring spaces: https://github.com/go-gitea/gitea/pull/33788/files?diff=split&w=1

Manually tested:

  • Admin notice
  • Authentication Sources (new/edit)
  • Admin Users (new/edit)

@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 4, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@wxiaoguang wxiaoguang merged commit 163bbca into go-gitea:main Mar 4, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-admin-ts branch March 4, 2025 15:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 5, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Upgrade golang net from 0.35.0 -> 0.36.0 (go-gitea#33795)
  Remove context from git struct (go-gitea#33793)
  Small refactor to reduce unnecessary database queries and remove duplicated functions (go-gitea#33779)
  Refactor repo-issue.ts (go-gitea#33784)
  Refactor repo-settings.ts (go-gitea#33785)
  Refactor admin/common.ts (go-gitea#33788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants