Skip to content

Disable vet=off again #33794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2025
Merged

Disable vet=off again #33794

merged 3 commits into from
Mar 5, 2025

Conversation

silverwind
Copy link
Member

Ref: #33792

Let's run this on CI a few times to see if it really improves test performance as suggested in the issue.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 4, 2025
@silverwind silverwind mentioned this pull request Mar 4, 2025
Closed
@silverwind silverwind marked this pull request as draft March 4, 2025 19:30
delvh
delvh approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@silverwind
Copy link
Member Author

8m9s for the first test run, restarting.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review March 5, 2025 09:14
@wxiaoguang
Copy link
Contributor

I think it is as fast as before now, let's merge.

@wxiaoguang wxiaoguang merged commit 95efc7b into go-gitea:main Mar 5, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 5, 2025
@wxiaoguang wxiaoguang deleted the testvet branch March 5, 2025 09:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 6, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3f775bc 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Refactor: move part of updating protected branch logic to service layer (go-gitea#33742)
  Update changelog for v1.23.5 (go-gitea#33797)
  Email option to embed images as base64 instead of link (go-gitea#32061)
  Update TypeScript types (go-gitea#33799)
  Disable vet=off again (go-gitea#33794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @wxiaoguang @delvh @GiteaBot