Skip to content

Improve repo commit view #33877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

Improve repo commit view #33877

merged 4 commits into from
Mar 14, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #24623

Major changes:

  1. Redirect /owner/repo/blob/* requests to /owner/repo/src/commit/* (like GitHub)
  2. Add a "view file diff" link (see screenshot below)
  3. Refactor "AssertHTMLElement" to generic, now we can accurately assert existence or number.
  4. Add more tests

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 14, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 14, 2025
Closed
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Mar 14, 2025
silverwind
silverwind reviewed Mar 14, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2025
delvh
delvh approved these changes Mar 14, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 14, 2025 07:30
@wxiaoguang wxiaoguang merged commit b094f9b into go-gitea:main Mar 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 14, 2025
@wxiaoguang wxiaoguang deleted the improve-repo-view branch March 14, 2025 07:49
@wxiaoguang wxiaoguang mentioned this pull request Mar 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Rework blob endpoint to match the standard convention
4 participants
@wxiaoguang @silverwind @delvh @GiteaBot