Fix markup content overflow #34072
Merged
Fix markup content overflow #34072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Mar 30, 2025
github-actions
bot
added
the
modifies/templates
techknowlogick
added
skip-changelog
github-actions
bot
removed
the
modifies/templates
- `SSL_CIPHER_SUITES`: **ecdhe_ecdsa_with_aes_256_gcm_sha384,ecdhe_rsa_with_aes_256_gcm_sha384,ecdhe_ecdsa_with_aes_128_gcm_sha256,ecdhe_rsa_with_aes_128_gcm_sha256,ecdhe_ecdsa_with_chacha20_poly1305,ecdhe_rsa_with_chacha20_poly1305**: Set the preferred cipher suites.
Maybe it only needs this
|
|
Sorry, an operational error occurred. Reopen now! |
wxiaoguang
approved these changes
Mar 31, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 31, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 1, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin fix users being able bypass limits with repo transfers (go-gitea#34031) Improve pull request list api (go-gitea#34052) fix(go-gitea#34076):replace assgniee translation key (go-gitea#34077) [Fix] Resolve the problem of commit_statuses not being loaded at the top - right when switching files from the file tree (go-gitea#34079) Enable testifylint rules (go-gitea#34075) Fix markup content overflow (go-gitea#34072)
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Apr 13, 2025
Fix go-gitea#34069: use `overflow-wrap: anywhere` to correctly wrap overflowed content. (cherry picked from commit 0fd5392)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
May 24, 2025
This has been introduced in the cherry-picked commit from go-gitea/gitea#34072 To me, adding this seems to be a bug as it forces a hard stop to any overflow nested within a markup div. Why should it be removed again? Because otherwise (wide) markdown tables might look super odd because the column breaking/wrapping logic is strange (likely related to the "anywhere" strategy being used). - [Example of current state with `overflow-wrap`](https://codefloe.com/devxy/helm-rdepot/src/branch/main/charts/rdepot) - [Example with `overflow-wrap` being removed](https://codefloe.com/devxy/helm-rdepot/src/branch/main/charts/rdepot) | Current | Patched | |---------|---------| |  |  | The initial change in Gitea was motivated to resolve issues of content overflow caused by the expandable file list tree view they introduced lately. However, this seem to have caused the whole README to overflow in their case, which doesn't apply to Forgejo. When removing this in Forgejo, only large markdown content (i.e. tables) are allowed to overflow. The whole README div will not overflow (I tested this with an extreme markdown table case). These tables are then horizontally scrollable, similar to how GitHub handles this. If the expandable tree view is going to be added to Forgejo, this should then be handled entirely differently. This specific change is not a solution. I've also checked other value settings to `overflow-wrap` but none had any or any desirable effect. I did not check all other possible CSS-related options for overflow*, but this might as well be a different task per se. For the reasons outlined above, I am quite certain this change should be reverted (again). Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7945 Reviewed-by: Gusted <[email protected]> Reviewed-by: Otto <[email protected]> Co-authored-by: pat-s <[email protected]> Co-committed-by: pat-s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34069: use
overflow-wrap: anywhereto correctly wrap overflowed content.