Skip to content

Support creating relative link to raw path in markdown #34105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #34104

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 2, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Apr 2, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 2, 2025
@wxiaoguang wxiaoguang merged commit 285950a into go-gitea:main Apr 2, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-repo-src-raw branch April 2, 2025 17:05
@juleskers
Copy link

Wow! That was quick! 🚀
Thanks a lot @wxiaoguang

I don't speak go, but I can write documentation.
Is there anywhere that I can document this new feature?

I tried searching for "markdown" on docs.gitea.com, but didn't find any markdown syntax overview.. Only "you can use markdown in X context like so"
Is there a "gitea flavoured markdown" reference somewhere?

@lunny
Copy link
Member

lunny commented Apr 2, 2025

Wow! That was quick! 🚀 Thanks a lot @wxiaoguang

I don't speak go, but I can write documentation. Is there anywhere that I can document this new feature?

I tried searching for "markdown" on docs.gitea.com, but didn't find any markdown syntax overview.. Only "you can use markdown in X context like so" Is there a "gitea flavoured markdown" reference somewhere?

Not any more but we can have a new one. Documentations' PRs are welcome.

@wxiaoguang
Copy link
Contributor Author

I tried searching for "markdown" on docs.gitea.com, but didn't find any markdown syntax overview.. Only "you can use markdown in X context like so"
Is there a "gitea flavoured markdown" reference somewhere?

Thank you very much. Maybe we can add a new page in https://gitea.com/gitea/docs/src/branch/main/docs/usage

There is no "gitea flavoured markdown" , actually Gitea does its best to follow GitHub's behavior. There might be some dialects in Gitea's markdown render (for example, we need to drop some syntaxes like #27645), but I can't recall all at the moment ..... so maybe we can just start the document and improve later.

🙏

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2025
* giteaofficial/main:
  Refactor Branch struct in package modules/git (go-gitea#33980)
  Support creating relative link to raw path in markdown (go-gitea#34105)
  Add new CLI flags to set name and scopes when creating a user with access token (go-gitea#34080)
  Do not show 500 error when default branch doesn't exist (go-gitea#34096)
  Return default avatar url when user id is zero rather than updating database (go-gitea#34094)
  [skip ci] Updated translations via Crowdin
  Fix return bug (go-gitea#34093)
  Move ParseCommitWithSSHSignature to service layer (go-gitea#34087)
  fix(i18n): clarify ownership in password change error messages (go-gitea#34092)
  Enable addtional linters (go-gitea#34085)
  Add flat-square action badge style (go-gitea#34062)
  Fix some UI bugs and clean up unused tests (go-gitea#34088)
juleskers added a commit to juleskers/playground that referenced this pull request Apr 3, 2025
@wxiaoguang
Copy link
Contributor Author

I proposed a first simple version: https://gitea.com/gitea/docs/pulls/198/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot create *relative* link to *raw* view in markdown.
5 participants