Fix column removal in MSSQL #3638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 35.92% 35.89% -0.04%
==========================================
Files 286 286
Lines 41257 41286 +29
==========================================
- Hits 14823 14820 -3
- Misses 24255 24286 +31
- Partials 2179 2180 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lunny
requested changes
Mar 7, 2018
models/migrations/migrations.go
Outdated
| return fmt.Errorf("Find constraints: %v", err) | ||
| } | ||
| for _, constraint := range constraints { | ||
| if _, err := x.Exec(fmt.Sprintf("ALTER TABLE `%s` DROP CONSTRAINT `%s`", tableName, constraint)); err != nil { |
There was a problem hiding this comment.
Alter table is not transactional but I can add it
|
@lunny done |
lafriks
force-pushed
the
fix/mssql_drop_column
branch
from
5ffd16f to
8d92ba4
Compare
lunny
approved these changes
Mar 7, 2018
tboerger
added
lgtm/need 1
|
MSSQL alter table is actually transaction so I added transaction as well |
appleboy
approved these changes
Mar 7, 2018
tboerger
added
lgtm/done
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Mar 7, 2018
* Fix column removal in MSSQL * Use xorm session in MSSQL drop column operations * Add transaction as MSSQL alter table is transactional
lafriks
added a commit
that referenced
this pull request
Mar 7, 2018
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Jan 23, 2025
Fix go-gitea#3638 This is a manual Forgejo-specific version of the Gitea PR go-gitea#30862. The weekly Forgejo PR go-gitea#3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes). Only occurs with Webkit in Safari over eg `http://192..`. (not localhost). See https://webkit.org/blog/10855/async-clipboard-api/ --- **Before**  **After**  Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805 Reviewed-by: Otto <[email protected]> Co-authored-by: David Davies-Payne <[email protected]> Co-committed-by: David Davies-Payne <[email protected]> (cherry picked from commit e4c3c03)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3624