Replaced docker docs with netlify deployment #4420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfranz
added
type/docs
techknowlogick
approved these changes
Jul 11, 2018
bkcsoft
added
the
lgtm/need 1
|
CI fail seems unrelated |
|
Yep, fails because of the flaky swagger stuff. |
|
@xxxTonixxx why confused? because I missed the explanation of the PR? |
jonasfranz
approved these changes
Jul 11, 2018
bkcsoft
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #4420 +/- ##
=======================================
Coverage 20.06% 20.06%
=======================================
Files 153 153
Lines 30769 30769
=======================================
Hits 6174 6174
Misses 23652 23652
Partials 943 943Continue to review full report at Codecov.
|
|
@tboerger yes, thanks for clarify 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to clarify the intention of this PR for those who have not been involved into the discussion. I have created an account at Netlify (a free static website hosting service including a worldwide CDN) where we want to host our website, blog, redirects and docs.
This PR enables the Drone pipeline to deploy the docs directly to Netlify, after a successful merge and build we just need to switch the DNS records.