Chages in the error notation #1769
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this causes all of our tests to fail because we're probably matching the old format in some scripts. |
|
It's fixed. But I think that those scripts should use json output. Human-readable output is not really meant for that. |
|
I'm still wondering where this notation comes from. I managed to find some kind of default regexes in VSCode here: https://github.com/microsoft/vscode/blob/fad39b690188aa2a5e9ebe87c3d51ee1afdf9dfd/src/vs/workbench/contrib/tasks/common/problemMatcher.ts#L1491-L1603. But none of them matches the format with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the VS Code terminal, it is possible to click on error messages to go directly to the error range involved. Turns out the error format is slightly different than the one used by Goblint.
Goblint does:
file : line : column - line : columnwhile VS Code recognise by defaultfile : line . column - line . column.This PR fixes that.
I tried with a default VS Code configuration without any extensions installed, and it works.