Fixing bug in iat validation when enabled #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using parser options to set
WithIssuedAt()in my application code, and noticed my unit test unexpectedly did not fail when my test JWTs omitted this field.Upon inspecting the code, I found
Validate()seemed to passv.verifyIssuedAtthe valuefalsefor therequiredargument, which effectively ignores validation for this field when its explicitly configured viaWithIssuedAt().Further, I added a testcase to the
validator_test.gounit tests, and found that my unit test was not failing when I changed back to the old code. Upon inspection, I found that an errant if statement was only testing if the error messages matched if there was an error at all, which will not test if there is not an error even when one is expected.