Skip to content

cmd/go: test sums of zip files created in direct mode #35290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jayconrod opened this issue Oct 31, 2019 · 5 comments
Closed

cmd/go: test sums of zip files created in direct mode #35290

jayconrod opened this issue Oct 31, 2019 · 5 comments
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@jayconrod
Copy link
Contributor

We currently have minimal test coverage on code that creates module zip files from repositories.

We should have a test that fails if the sum changes for a zip created for a given module path and version.

The test should also alert us when the SHA-256 sum of the created zip file changes. These sums don't need to be stable; only content sums must not change. However, we should be aware of accidental changes to the way zip files are built.
@jayconrod jayconrod added NeedsFix The path to resolution is known, but the work has not been done. GoCommand cmd/go modules labels Oct 31, 2019
@jayconrod jayconrod added this to the Go1.14 milestone Oct 31, 2019
@jayconrod jayconrod self-assigned this Oct 31, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/204643 mentions this issue: cmd/go/internal/modfetch: add zip sums and hashes to TestCodeRepo

gopherbot pushed a commit that referenced this issue Nov 1, 2019
cmd/go/internal/modfetch: add zip sums and hashes to TestCodeRepo
24e9c53 
Updates #35290

Change-Id: I09cad17f09e78c2bf6a9de98b01f13ed383ca006
Reviewed-on: https://go-review.googlesource.com/c/go/+/204643
Run-TryBot: Jay Conrod <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/204838 mentions this issue: cmd/go/internal/modfetch/zip_sum_test: long test for zip sum stability

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/204917 mentions this issue: cmd/go/internal/modfetch: switch to golang.org/x/mod/zip

gopherbot pushed a commit that referenced this issue Nov 7, 2019
cmd/go/internal/modfetch: switch to golang.org/x/mod/zip
0bf2eb5 
zip.Create is now used to filter and translate zip files from VCS tools.

zip.Unzip is now used instead of Unzip.

Fixes #35290

Change-Id: I4aa41b2e96bf147c09db43d1d189b8393cafb06f
Reviewed-on: https://go-review.googlesource.com/c/go/+/204917
Run-TryBot: Jay Conrod <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/218917 mentions this issue: cmd/go/internal/modfetch/zip_sum_test: remove dead versions

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/220640 mentions this issue: cmd/go/internal/modfetch: delete unused isVendoredPackage function

gopherbot pushed a commit that referenced this issue Feb 24, 2020
cmd/go/internal/modfetch: delete unused isVendoredPackage function
78a608d 
This function is apparently unused since CL 204917.

Updates #35290
Updates #37397

Change-Id: Id7f5f5d5176fdbd1c5c6227e81d0854ceafc3f12
Reviewed-on: https://go-review.googlesource.com/c/go/+/220640
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
gopherbot pushed a commit that referenced this issue Mar 18, 2020
cmd/go/internal/modfetch/zip_sum_test: remove dead versions
6197104 
* gitlab.com/yumeko/MumbleEmu: the go-import tag now points to
  gitlab.com/yumeko/mumbleemu, but the module path hasn't changed
  in go.mod.
* github.com/openshift/api: tag v3.9.0 was deleted.
* github.com/AlexStocks/log4go: tag v1.0.5 was deleted.
* github.com/belogik/goes: repository is no longer available.
* llvm.org/llvm: server times out and disconnects after 30-40 mins.

Also, fix a typo in an error message.

With these versions removed, zip_sum_test passes.

Updates #35290

Change-Id: Id3bdb8675a5582f88a6ff4c12dd7d1abe31aa56f
Reviewed-on: https://go-review.googlesource.com/c/go/+/218917
Run-TryBot: Jay Conrod <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot