-
Notifications
You must be signed in to change notification settings - Fork 18.1k
crypto/rand: make Read not escape the byte slice #66801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: a16041b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 0654f22) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-12T19:04:09Z","revision":"af8e49a2bd486cd303a3c8847c5bbf1c04115086"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-12T19:10:40Z","revision":"f70f54162b68f90ffa0eb5800d0ad6cae47f2da7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: f6234dc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T05:48:21Z","revision":"98c3ed463e44bd7a0424fce0c7c88571a281bdfa"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 81fe51c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T06:28:15Z","revision":"90bf2555ac1ed46fb151d2c60a4f710259db01b5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: c63aa96) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 5: Commit-Queue+1 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T06:45:31Z","revision":"8105df94bbbdcea6c9dd12e1ab293424d4db61ee"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 423f7fe) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Filippo Valsorda: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Change-Id: Ifd4458aad3021280f35f68b8589ef50920d7cadd
Change-Id: I6d06cb1487e96dff781ec43fd3692f537fe158e1
Change-Id: I250cfc50b9d26aa6f69a82553f21ce3403d8f520
Change-Id: I026f0b9056743873d47f7d82f0806ce52abba5f4
Change-Id: If592cc206c128e6900f9edf5d2170962692e4b7a
Change-Id: Id2933260a99998fa7b5881a5ec73fae73a8a0056
Change-Id: I48001745916ed3dded163c48952277a88e546b24
Change-Id: Ibd76a9eee139c278daf50db693c20a6e423a4973
Change-Id: I8ff1fe961bf1619a6dde85f079e8f195d29f5c2b
Change-Id: I97e048564860f1f409b2ffc02463f16c9dccfccb
bfdb438
to
f6039aa
Compare
This PR (HEAD: f6039aa) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 13: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-22T15:54:17Z","revision":"7a449ef9ec03521ff37a753afba8a967fd31e3de"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 13: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 13: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Closing in favour of CL 602498 |
ReadAllocs-12 3.050µ ± 0% 2.912µ ± 0% -4.52% (p=0.000 n=10)
ReadAllocs-12 320.2Mi ± 0% 335.3Mi ± 0% +4.73% (p=0.000 n=10)
ReadAllocs-12 1.000Ki ± 0% 0.000Ki ± 0% -100.00% (p=0.000 n=10)
ReadAllocs-12 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)