-
Notifications
You must be signed in to change notification settings - Fork 123
rate: simplify function advance only returns new Tokens to caller #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: e608dfb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/645995. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-02T06:14:37Z","revision":"1bd69541cfc8bc2e9d5d7389dbf13376553c96c9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
This PR (HEAD: 2de685c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/645995. Important tips:
|
This PR (HEAD: ada1ca5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/645995. Important tips:
|
Message from 黄翀: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from 黄翀: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
This PR (HEAD: 1bc7316) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/time/+/645995. Important tips:
|
Message from 黄翀: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 6: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-05T00:53:28Z","revision":"41597c3169b9f62975598876782b7c4e9ba34f75"} Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Ian Lance Taylor: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/645995. |
Change the advance method to stop returning the newT result, because it is always the same as the t argument. Change-Id: Ib04017715d9f38f4ef6b908cb3d3b09af01b50b7 GitHub-Last-Rev: 1bc7316 GitHub-Pull-Request: #24 Reviewed-on: https://go-review.googlesource.com/c/time/+/645995 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
This PR is being closed because golang.org/cl/645995 has been merged. |
Change the advance method to stop returning the newT result,
because it is always the same as the t argument.