Skip to content

doc: Add notes for annotation config #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 16, 2025

I tried to configure annotations and it didn't fully function as I wasn't using setup-go in the same job (but did in other jobs in the same config). This note might help others to avoid the same issue.

Instead of setup-go the problem matcher of golangci-lint-action also works, but I assume that's not the recommended way as the examples all use setup-go.

@ldez
Copy link
Member

ldez commented Feb 16, 2025

Hello,

Your modification is not right: actions/setup-go is not needed, you have an option to enable the internal problem matcher: https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#problem-matchers

@ldez ldez closed this Feb 16, 2025
@ldez ldez added the declined label Feb 16, 2025
@ldez ldez changed the title README: Add notes for annotation config doc: Add notes for annotation config Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants