Proper compilation errors for resource constructor args and type parameters #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1584 and Fix #1583
Resource constructor related (2 issues)
Before
let r = x.cart(1)
is a success which is wrong. Also internal names getting exposed such as[constructor](..)
in the error messagesAfter
Type Parameters related
Before
function foo doesn't exist in golem:it/api
while the actual error isgolem:it/api2
doesn't existAfter
Along with these fixes, the function names(resource constructors, method names etc) in some of the error messages was fully qualified (or raw versions) such as
[constructor]cart
) and these are being fixed in this PR as well.