Skip to content

fix: crashing while exiting loop agent in web #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: crashing while exiting loop agent in web #566

wants to merge 15 commits into from

Conversation

kavinkumar807
Copy link
Contributor

This PR fixes #501

  • refactored the tracer.start_as_current_span with start_span to manually handle the context var detach
  • There was a issue where the event was not yielded on escalation, added fix for that too
  • There was a formatting issue src/google/adk/sessions/database_session_service.py fixed that too

Refs:

  1. opentelemetry.io
  2. cncf
  3. opentelemetry-python
  4. open-telemetry-issue-2787

@kavinkumar807 kavinkumar807 changed the title Crash while exiting loop agent in adk web fix: crashing while exiting loop agent in web May 5, 2025
@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl raised PR

@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl Synced the branch

@kavinkumar807
Copy link
Contributor Author

kavinkumar807 commented May 6, 2025 •
edited
Loading

@hangfei @boyangsvl Synced the PR with the main

@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl Synced the PR with the main

@DeanChensj DeanChensj requested a review from hangfei May 7, 2025 22:22
@kavinkumar807
Copy link
Contributor Author

@hangfei @boyangsvl @DeanChensj Synced the PR the main

@kavinkumar807
Copy link
Contributor Author

@hangfei @DeanChensj Synced PR with main

@kavinkumar807
Copy link
Contributor Author

@hangfei Synced the branch with main

@hangfei
Copy link
Collaborator

hangfei commented May 30, 2025

@selcukgun Please help review this change.

@hangfei hangfei requested a review from selcukgun May 30, 2025 18:01
@takumiohym takumiohym mentioned this pull request Jun 5, 2025
Open
NoorZia pushed a commit to NoorZia/adk-python that referenced this pull request Jun 7, 2025
Add changes from PR#566 (google#566)
63f3bcc
facundovictor added a commit to facundovictor/adk-python that referenced this pull request Jun 8, 2025
@facundovictor
fix: Apply PR-566
e27d4a3 
See: google#566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangfei hangfei Awaiting requested review from hangfei

@selcukgun selcukgun Awaiting requested review from selcukgun

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash while exiting loop agent in adk web
2 participants
@kavinkumar807 @hangfei