Skip to content

feat: add refresh feature for OAuth2 refresh token #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

feat: add refresh feature for OAuth2 refresh token #581

wants to merge 0 commits into from

Conversation

anencore94
Copy link
Contributor

@anencore94 anencore94 commented May 6, 2025 •
edited
Loading

fixes "# TODO(cheliu): Implement token refresh flow" @pwwpche

  • add expiry field for OAuth2Auth
  • use refresh_token if there isn't any access_token or expired.

@hangfei
Copy link
Collaborator

hangfei commented May 30, 2025

@seanzhou1023 Please help review this change.

@anencore94 please resolve the conflict.s

@hangfei hangfei requested a review from seanzhou1023 May 30, 2025 19:18
@hangfei hangfei added the tools Issues related to tools label May 30, 2025
@anencore94 anencore94 closed this May 31, 2025
@anencore94 anencore94 force-pushed the fix/oauth2_refresh branch from d197c83 to 7fdc6b4 Compare May 31, 2025 08:05
@anencore94 anencore94 mentioned this pull request May 31, 2025
Open
@anencore94
Copy link
Contributor Author

I removed my original branch by mistake, so I submit another pull request with same change list. PTAL @hangfei @seanzhou1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanzhou1023 seanzhou1023 Awaiting requested review from seanzhou1023

Assignees
No one assigned
Labels
tools Issues related to tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anencore94 @hangfei