Skip to content

Fix cache reporting with cgroup hierarchy #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Fix cache reporting with cgroup hierarchy #2014

merged 1 commit into from
Aug 15, 2018

Conversation

vboginskey
Copy link
Contributor

This makes the behavior of container_memory_cache consistent with container_memory_rss for hierarchical cgroups. See #2008 for more detail.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@vboginskey
Copy link
Contributor Author

I signed the CLA.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dashpole
Copy link
Collaborator

dashpole commented Aug 5, 2018

/ok-to-test

@dashpole dashpole self-assigned this Aug 5, 2018
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dashpole dashpole merged commit d8d7bf8 into google:master Aug 15, 2018
@vboginskey vboginskey deleted the use-hierarchy-for-cache branch August 16, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants