Update to Rust 2024 edition. #2658
Conversation
qwandor
force-pushed
the
edition2024
branch
2 times, most recently
from
40a6949 to
05c4b7d
Compare
qwandor
force-pushed
the
edition2024
branch
2 times, most recently
from
52c320f to
f5787fe
Compare
qwandor
force-pushed
the
edition2024
branch
2 times, most recently
from
815bdd5 to
b9641a7
Compare
|
This is blocked on a new version of |
There was a problem hiding this comment.
When trying to manually build the book with these changes (after manual installation of mdbook-svgbob from the git repo - as there is no release yet) I get this error from linkcheck (0.7.7)
$ mdbook build
2025-04-17 09:29:35 [INFO] (mdbook::book): Book building has started
2025-04-17 09:29:35 [INFO] (mdbook::book): Running the exerciser backend
2025-04-17 09:29:35 [INFO] (mdbook::renderer): Invoking the "exerciser" renderer
2025-04-17 09:29:35 [INFO] (mdbook::book): Running the html backend
2025-04-17 09:29:36 [INFO] (mdbook::book): Running the linkcheck backend
2025-04-17 09:29:36 [INFO] (mdbook::renderer): Invoking the "linkcheck" renderer
Error: Unable to parse RenderContext
Caused by:
unknown variant `2024`, expected one of `2021`, `2018`, `2015` for key `edition` at line 1 column 702979
2025-04-17 09:29:36 [ERROR] (mdbook::renderer): Renderer exited with non-zero return code.
2025-04-17 09:29:36 [ERROR] (mdbook::utils): Error: Rendering failed
2025-04-17 09:29:36 [ERROR] (mdbook::utils): Caused By: The "linkcheck" renderer failed
When linkcheck is disabled this change looks good to me.
Looks like |
qwandor
force-pushed
the
edition2024
branch
2 times, most recently
from
a7024aa to
47d9593
Compare
mdbook-linkcheck hasn't had a release in 2 years and doesn't support Rust 2024 edition.
It looks in the output.linkcheck section rather than its own.
| @@ -25,7 +25,7 @@ else | |||
| # Back-date the sources to POT-Creation-Date. The content lives in two | |||
| # directories: | |||
| rm -r src/ third_party/ | |||
| git restore --source "$(git rev-list -n 1 --before "$pot_creation_date" @)" src/ third_party/ | |||
| git restore --source "$(git rev-list -n 1 --before "$pot_creation_date" @)" src/ third_party/ book.toml | |||
There was a problem hiding this comment.
Heads up @jonodeno: I believe your google/mdbook-i18n-helpers#268 will need to be updated to take this into account.
Cc @michael-kerscher as well, who has been reviewing the other PR.
No description provided.