Skip to content

Determine if we want to log streaming responses in gapic-generator-python #2389

Open
@parthea

Description

@parthea

Capturing discussion from #2340.

Streaming responses are logged in google-api-core as of googleapis/python-api-core#794. We should determine if we want to move the streaming iterator to gapic-generator-python so we can inspect the next item and log it.

See the discussion in #2340 (comment).

This discussion will be captured in code so that if/when we decide to refactor the streaming logic, we can determine if we want to consolidate the logging logic.

Depending how we want to log (a) receiving a streaming response vs (b) exposing the next streamed item to the user, we could possibly want to log something here
(a) should always happen in api-core
(b) could happen in api-core, or it could happen here when we iterate to the next streamed item that was previously received.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions