Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

feat: optimize passing Bytes to Value #1104

Merged
merged 1 commit into from
Nov 22, 2019
Merged

feat: optimize passing Bytes to Value #1104

merged 1 commit into from
Nov 22, 2019

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Nov 22, 2019 •
edited by coryan
Loading

Now with more move support.

Fixes #1103

This change is Reviewable

@devjgm
feat: optimize passing Bytes to Value
8b7faa5 
Now with more move support.

Fixes googleapis#1103
@devjgm devjgm requested a review from coryan November 22, 2019 16:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #1104 into master will decrease coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   93.36%   92.81%   -0.56%     
==========================================
  Files         163      165       +2     
  Lines       12201    12206       +5     
==========================================
- Hits        11392    11329      -63     
- Misses        809      877      +68
Impacted Files Coverage Δ
google/cloud/spanner/value.h 92.8% <ø> (ø) ⬆️
google/cloud/spanner/bytes.h 100% <ø> (ø) ⬆️
google/cloud/spanner/value.cc 97.25% <100%> (ø) ⬆️
google/cloud/spanner/bytes.cc 100% <100%> (ø) ⬆️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 69.96% <0%> (-10.84%) ⬇️
...tegration_tests/instance_admin_integration_test.cc 86.2% <0%> (-9.2%) ⬇️
...loud/spanner/internal/partial_result_set_resume.cc 90.9% <0%> (-4.55%) ⬇️
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
...loud/spanner/internal/partial_result_set_source.cc 93.24% <0%> (-1.36%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df2f3f...8b7faa5. Read the comment docs.

coryan
coryan approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, thanks!

@devjgm devjgm merged commit 07dbbc4 into googleapis:master Nov 22, 2019
@devjgm devjgm deleted the opt-bytes-move branch November 22, 2019 17:24
devjgm added a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
@devjgm
feat: optimize passing Bytes to Value (googleapis/google-cloud-cpp-sp…
b09298e 
…anner#1104)

Now with more move support.

Fixes googleapis/google-cloud-cpp-spanner#1103
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize MakeValueProto(Bytes) using move semantics
3 participants
@devjgm @coryan @googlebot