Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

feat: add build to check API breakage #1155

Merged
merged 2 commits into from
Dec 17, 2019
Merged

feat: add build to check API breakage #1155

merged 2 commits into from
Dec 17, 2019

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 16, 2019

Set API baseline, create the builds and scripts to check it.

Fixes #651


This change is Reviewable

Set API baseline, create the builds and scripts to check it.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2019
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1155 into master will increase coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
+ Coverage   93.71%   95.74%   +2.02%     
==========================================
  Files         170      169       -1     
  Lines       13155    13151       -4     
==========================================
+ Hits        12328    12591     +263     
+ Misses        827      560     -267
Impacted Files Coverage Δ
...on_tests/rpc_failure_threshold_integration_test.cc 85.71% <0%> (-2.07%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 81.57% <0%> (-1.76%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.96% <0%> (-0.01%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
google/cloud/spanner/instance_admin_connection.h
google/cloud/spanner/samples/samples.cc 86.37% <0%> (+0.28%) ⬆️
google/cloud/spanner/internal/spanner_stub.cc 70.32% <0%> (+1.09%) ⬆️
google/cloud/spanner/internal/polling_loop.h 94.59% <0%> (+2.7%) ⬆️
google/cloud/spanner/internal/retry_loop.h 100% <0%> (+4.54%) ⬆️
...loud/spanner/internal/partial_result_set_resume.cc 95.45% <0%> (+4.54%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de21856...9bc54aa. Read the comment docs.

@coryan coryan marked this pull request as ready for review December 16, 2019 19:58
@coryan coryan merged commit c872116 into googleapis:master Dec 17, 2019
@coryan coryan deleted the implement-check-api-build branch December 17, 2019 04:25
@devbww
Copy link
Contributor

devbww commented Dec 17, 2019

For what it's worth, I saw these messages flash by.

Detect public symbols
ERROR: requires Universal Ctags to work properly
Reading debug-info
WARNING: the object should be compiled with -Og option for better analysis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup builds to detect API breakage
3 participants