This repository was archived by the owner on Dec 8, 2021. It is now read-only.
bug: number of channels was inadvertently limited to 1 #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent was to ensure the number of channels was "at least one", but instead actually made it "at most one". There is no test for this because client_test uses the Client constructor directly. We should try to add one, but let's fix this obvious bug first.
googlebot
added
the
cla: yes
devbww
approved these changes
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
- Coverage 95.78% 95.72% -0.07%
==========================================
Files 174 173 -1
Lines 13483 13480 -3
==========================================
- Hits 12915 12904 -11
- Misses 568 576 +8
Continue to review full report at Codecov.
|
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…ogle-cloud-cpp-spanner#1169) * bug: number of channels was inadvertently limited to 1 The intent was to ensure the number of channels was "at least one", but instead actually made it "at most one". There is no test for this because client_test uses the Client constructor directly. We should try to add one, but let's fix this obvious bug first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent was to ensure the number of channels was "at least one",
but instead actually made it "at most one".
There is no test for this because client_test uses the Client
constructor directly. We should try to add one, but let's fix
this obvious bug first.
This change is