This repository was archived by the owner on Dec 8, 2021. It is now read-only.
feat: make emulator endpoint/credentials changes as late as possible #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than making the `${SPANNER_EMULATOR_HOST}` endpoint/credentials
changes during `ConnectionOptions` construction (which then requires
that we ignore further attempts to set those fields), do them as late
as possible (i.e., just before creating each variety of channel).
This then facilitates the use of a common `ConnectionOptions` class
between Cloud C++ projects by not requiring special behavior in the
`set` functions.
While this modifies the signatures of `CreateDefault*Stub()`, it is
only a change from pass-by-const-ref to pass-by-value, which will not
require any change to user code.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
+ Coverage 94.61% 94.61% +<.01%
==========================================
Files 178 180 +2
Lines 13830 13828 -2
==========================================
- Hits 13085 13084 -1
+ Misses 745 744 -1
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 21, 2020
devjgm
approved these changes
Feb 21, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…oogleapis/google-cloud-cpp-spanner#1277) Rather than making the `${SPANNER_EMULATOR_HOST}` endpoint/credentials changes during `ConnectionOptions` construction (which then requires that we ignore further attempts to set those fields), do them as late as possible (i.e., just before creating each variety of channel). This then facilitates the use of a common `ConnectionOptions` class between Cloud C++ projects by not requiring special behavior in the `set` functions. While this modifies the signatures of `CreateDefault*Stub()`, it is only a change from pass-by-const-ref to pass-by-value, which will not require any change to user code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than making the
${SPANNER_EMULATOR_HOST}endpoint/credentialschanges during
ConnectionOptionsconstruction (which then requiresthat we ignore further attempts to set those fields), do them as late
as possible (i.e., just before creating each variety of channel).
This then facilitates the use of a common
ConnectionOptionsclassbetween Cloud C++ projects by not requiring special behavior in the
setfunctions.While this modifies the signatures of
CreateDefault*Stub(), it isonly a change from pass-by-const-ref to pass-by-value, which will not
require any change to user code.
This change is