-
Notifications
You must be signed in to change notification settings - Fork 14
feat: moved quickstart/ -> google/cloud/spanner/ #1479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a draft PR and asking for a review at the same time is a mixed message.
Reviewed 23 of 23 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww, @mr-salty, and @scotthart)
I thought it only notified reviewers after I clicked the "ready for review" button. I assumed that I was just filling in the reviewers field, and they'd be notified once it was ready.... the github UI for draft PRs is itself a mixed message. But sorry about that. TIL. |
Hmm... Maybe. I am subscribed to get everything in |
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 95.61% 95.60% -0.02%
==========================================
Files 194 192 -2
Lines 15919 15934 +15
==========================================
+ Hits 15221 15233 +12
- Misses 698 701 +3
Continue to review full report at Codecov.
|
…loud-cpp-spanner#1479) * feat: moved quickstart/ -> google/cloud/spanner/ Fixes: googleapis#3973 * fixed quickstart path in build script
Fixes: googleapis/google-cloud-cpp#3973
This change is