Skip to content

deps: update dependency com.google.cloud:sdk-platform-java-config to v3.49.0 #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 2, 2025

trying to exclude re2j that causes conflict for now. See #2134 (comment)

maven-enforcer error updating sdk-platform-java-config:

Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce) on project google-cloud-firestore: 
Error:  Rule 2: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
Error:  Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Error:  Require upper bound dependencies error for com.google.re2j:re2j:1.7 [runtime] paths to dependency are:
Error:  +-com.google.cloud:google-cloud-firestore:3.31.6-SNAPSHOT
Error:    +-com.google.cloud.opentelemetry:exporter-metrics:0.33.0
Error:      +-com.google.cloud:google-cloud-monitoring:3.52.0
Error:        +-com.google.re2j:re2j:1.7 [runtime]
Error:  and
Error:  +-com.google.cloud:google-cloud-firestore:3.31.6-SNAPSHOT
Error:    +-com.google.api:gax-grpc:2.67.0
Error:      +-io.grpc:grpc-googleapis:1.71.0 [runtime] (managed) <-- io.grpc:grpc-googleapis:1.71.0 [runtime]
Error:        +-io.grpc:grpc-xds:1.71.0 [runtime] (managed) <-- io.grpc:grpc-xds:1.71.0 [runtime]
Error:          +-com.google.re2j:re2j:1.8 [runtime]

@zhumin8 zhumin8 requested review from a team as code owners June 2, 2025 20:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Jun 2, 2025
@zhumin8 zhumin8 requested review from suztomo and blakeli0 June 3, 2025 15:11
@zhumin8
Copy link
Contributor Author

zhumin8 commented Jun 3, 2025

Actually, this exporter-metrics is part of java-shared-dependencies/third-party-dependencies. We might want to consider test and capture conflicts within sdk-platform-java.

https://github.com/googleapis/sdk-platform-java/blame/5b2ab829888631caa382621570910187de45ce1c/java-shared-dependencies/third-party-dependencies/pom.xml#L41

At the moment, the latest version of exporter-metrics still brings in an older google-cloud-monitoring version with this issue

  +-com.google.cloud.opentelemetry:exporter-metrics:0.35.0
     +-com.google.cloud:google-cloud-monitoring:3.52.0
       +-com.google.re2j:re2j:1.7 [runtime]

@zhumin8 zhumin8 merged commit 4006eaf into main Jun 4, 2025
33 of 34 checks passed
@zhumin8 zhumin8 deleted the sdk-platform-java-config branch June 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants