feat: Add support for multiplexed sessions - partitioned #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
…E_MULTIPLEXED_SESSIONS` and add unit tests. Signed-off-by: Taylor Curran <[email protected]>
currantw
force-pushed
the
support-mux-session-2
branch
from
57902b4 to
c8e7a1c
Compare
lszinv
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…` exception from `DatabaseSessionManager` and add unit tests. Signed-off-by: Taylor Curran <[email protected]>
rahul2393
reviewed
May 30, 2025
| environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED] = "true" | ||
| environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED_FOR_PARTITIONED] = "true" | ||
| environ[SessionOptions.ENV_VAR_ENABLE_MULTIPLEXED_FOR_READ_WRITE] = "true" | ||
| environ[SessionOptions.ENV_VAR_FORCE_DISABLE_MULTIPLEXED] = "false" |
There was a problem hiding this comment.
We don't need to force disable multiplexed
There was a problem hiding this comment.
We don't need it at all? Is this environment variable is being completely removed from the scope of the project?
…essions, add unit tests. Signed-off-by: Taylor Curran <[email protected]>
Signed-off-by: Taylor Curran <[email protected]>
Signed-off-by: Taylor Curran <[email protected]>
currantw
force-pushed
the
support-mux-session-2
branch
from
0bd4e7b to
98e6b13
Compare
…shotBase` and update attributes and tests. Signed-off-by: Taylor Curran <[email protected]>
product-auto-label
bot
added
size: xl
…edundant as transaction ID is set via `_restart_on_unavailable`) Signed-off-by: Taylor Curran <[email protected]>
…to `Client` so that multiplexed are disabled for _all_ databases. Signed-off-by: Taylor Curran <[email protected]>
…Database.run_in_transaction` to not use it. Signed-off-by: Taylor Curran <[email protected]>
… cleanup. Signed-off-by: Taylor Curran <[email protected]>
…ession manager. Signed-off-by: Taylor Curran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add support for multiplexed sessions - partitioned:
TODO