feat: handle auto pagination for BigQuery v2 #3829
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure which checks are relevant/needed. Please let me know, |
|
/gcbrun |
blakeli0
reviewed
Jun 10, 2025
| PAGINATE_MAX_RESULT_TYPES = | ||
| ImmutableMap.of( | ||
| "com.google.cloud.bigquery.v2", | ||
| ImmutableMap.of( |
There was a problem hiding this comment.
I guess there are some legacy RPCs use max_results field and are not of wrapper types?
| // This is similar to the PagedExpand except that it uses | ||
| // max_results instead of page_size, as some legacy APIs still | ||
| // do. New APIs should NOT use this pattern. | ||
| rpc PagedExpandLegacy(PagedExpandLegacyRequest) returns (PagedExpandResponse) { |
There was a problem hiding this comment.
I don't think this test can prove much because the package is not bigquery, this is more like a negative test case which is already covered by other test cases. We need a positive golden test file that can demonstrate the changes.
There was a problem hiding this comment.
Are golden tests for this file missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, please read our contributing guidelines.
There are a few things you can do to make sure it goes smoothly:
Fixes # b/360114900 & b/352331075