Skip to content

Disable timeout handler #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Disable timeout handler #519

wants to merge 1 commit into from

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Apr 11, 2025

It suppresses panic stacktraces:
golang/go#27375

It suppresses panic stacktraces:
golang/go#27375
@drigz
Copy link
Contributor Author

drigz commented Apr 11, 2025

@csieber I don't know if the timeout handler has an important role here, should we submit this as-is or perhaps add a flag to turn it off?

@csieber
Copy link
Contributor

csieber commented Apr 11, 2025

@csieber I don't know if the timeout handler has an important role here, should we submit this as-is or perhaps add a flag to turn it off?

I guess without it the tv would crash the process on panic? I would leave it for now and add a flag to disable

@drigz
Copy link
Contributor Author

drigz commented Apr 14, 2025

I guess without it the tv would crash the process on panic? I would leave it for now and add a flag to disable

I don't believe so, when we disabled this we still saw the panic being gracefully caught by the http server: (full traceback is on the chat thread)

http: panic serving 10.88.3.28:56962: runtime error: invalid memory address or nil pointer dereference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants