Skip to content

Handle RESULT_CANCELED at onActivityResult to detect user cancel #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qua-iy
Copy link

@qua-iy qua-iy commented Aug 31, 2018

On android, if I cancel sign in dialog by tapping outside of the box, it will return SignInException with status of Error. This PR will fix this issue and it will return status of Cancel.
I think this is related to #53.

@violet7
Copy link

violet7 commented Oct 19, 2018

Wait for SignInFragment appear, minimize app, tap app icon, crash.
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'com.google.android.gms.auth.api.signin.GoogleSignInAccount com.google.android.gms.auth.api.signin.GoogleSignInResult.getSignInAccount()' on a null object reference

@qua-iy
Copy link
Author

qua-iy commented Oct 26, 2018

@violet7 Hi, I think your issue exists originally, because GoogleSignInResult.getSignInAccount() I did not changed place of calling or condition. I maybe fixed it, but I thinks it should be fixed in another PR.

@leongkee
Copy link

leongkee commented Jan 17, 2019

Hi. I am using the Google Sign-in Plugin from google-signin-plugin-1.0.4.unitypackage in the Unity project. The package is downloaded from https://github.com/googlesamples/google-signin-unity/releases/tag/v1.0.4.

It still give me error when I cancel the sign-in.
How could I get the version that has fixed this issue and will return the status of "Cancel"?

How do I merge this fix into the Unity project?
How do I modify the GoogleSignInFragment.java file?

Please advise. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants