support HTTP status 300 in pagination

[rootfs]

FIX #384

According to this line in Cinder, HTTP status 300 could return when blockstorage list API versions.

[jtopjian]

@rootfs Thanks for submitting this, but there are two issues to resolve first before someone can take a look:

1. There needs to be a corresponding Issue
2. There needs to be links to the actual code where a 300 is being returned. We can't go by API documentation alone.

Let me know if you have any questions.

[coveralls]

Coverage remained the same at 70.783% when pulling 7cc2c03 on rootfs:pagination-status into 8d5b28e on gophercloud:master.

[rootfs]

@jtopjian @jrperritt

[rootfs]

@jtopjian Thanks for the quick feedback, I updated the issue and the line in Cinder repo.

[jrperritt]

@rootfs That link is just the unrendered docs you originally linked. It needs to be a link to the Cinder source code.

[jtopjian]

To save @rootfs some time digging, here's the appropriate link: https://github.com/openstack/cinder/blob/3f8466b712d7a0b300c07d1d215c0dd256a769f7/cinder/api/versions.py#L125

@jrperritt off the top of your head, is pagination.Result the right place for this?

[rootfs]

@jtopjian @jrperritt I only found one here
https://github.com/openstack/cinder/blob/liberty-eol/cinder/api/versions.py#L240

[jrperritt]

@jtopjian

off the top of your head, is pagination.Result the right place for this

You mean pagination.Request? If so, then yes, all pagination requests flow through there.

[jtopjian]

You mean pagination.Request?

Yes - that one :)

OK, thanks. That saves me some time.

This looks good to me. A 300 result is certainly possible. I'm going to go ahead and merge.

[jtopjian]

Also, It looks like we can pull apiversions out of v1. No doubt more apiversions packages will be coming (notably with sharedfilesystems). Maybe it's best to standardize on that package located within the service directory and not a specific version directory.

[jtopjian]

@rootfs Thanks for catching this error and submitting the fix 😄

[rootfs]

Thank you @jtopjian @jrperritt !