fix breaking change in prom metrics validation scheme #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
mattdurham
approved these changes
Feb 20, 2025
wildum
approved these changes
Feb 20, 2025
dehaansa
approved these changes
Feb 20, 2025
thampiotr
added a commit
that referenced
this pull request
Feb 20, 2025
* fix breaking change in prom metrics validation scheme * add test and changelog * punctuation
thampiotr
added a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent upgrade of prommetheus/common brought in this PR: prometheus/common#724 which is a breaking change for Alloy.
In this PR I restore the old behaviour manually in Alloy's run command and expose the option to enable the new utf-8 behaviour optionally. This is done via CLI flag in first iteration, but may change in the future, so the flag is marked as experimental right away.