fix(pyroscope.java): Ensure the jfr is deleted on shutdown (#3630)

[aleks-p]

• fix(pyroscope.java): Ensure the jfr is deleted on shutdown

• Address review comments

• Improve log messages

(cherry picked from commit 28ad5ab)

[github-actions]

😢 zizmor failed with exit code 14.

Expand for full output

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/autolock.yml:19:9
   |
19 |       - uses: dessant/lock-threads@v5
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[dangerous-triggers]: use of fundamentally insecure workflow trigger
 --> ./.github/workflows/backport.yml:2:1
  |
2 | / on:
3 | |   pull_request_target:
4 | |     types:
5 | |       - closed
6 | |       - labeled
  | |_______________^ pull_request_target is almost always used insecurely
  |
  = note: audit confidence → Medium

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/check-linux-build-image.yml:30:9
   |
30 |         uses: docker/[email protected]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/check-linux-build-image.yml:33:9
   |
33 |         uses: docker/setup-buildx-action@v3
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/check-linux-build-image.yml:36:9
   |
36 |         uses: docker/build-push-action@v6
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/check-windows-build-image.yml:16:9
   |
16 |         uses: mr-smithers-excellent/docker-build-push@v6
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/create_build_image.yml:43:7
   |
43 |       uses: docker/[email protected]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/create_build_image.yml:46:7
   |
46 |       uses: docker/setup-buildx-action@v3
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/create_build_image.yml:49:7
   |
49 |       uses: docker/build-push-action@v6
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/depcheck.yml:15:9
   |
15 |         uses: rfratto/depcheck@main
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/fuzz-go.yml:28:9
   |
28 |         - name: Find fuzz tests
   |           ^^^^^^^^^^^^^^^^^^^^^ this step
29 |           id: find-tests
30 | /         run: |
31 | |           TEST_FILES=$(find "${{ inputs.directory }}" -name '*_test.go' -not -path './vendor/*')
...  |
61 | |
62 | |           echo 'tests=['$INCLUDE_STRING']' >> $GITHUB_OUTPUT
   | |____________________________________________________________^ inputs.directory may expand into attacker-controllable code
   |
   = note: audit confidence → Low

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/fuzz-go.yml:28:9
   |
28 |         - name: Find fuzz tests
   |           ^^^^^^^^^^^^^^^^^^^^^ this step
29 |           id: find-tests
30 | /         run: |
31 | |           TEST_FILES=$(find "${{ inputs.directory }}" -name '*_test.go' -not -path './vendor/*')
...  |
61 | |
62 | |           echo 'tests=['$INCLUDE_STRING']' >> $GITHUB_OUTPUT
   | |____________________________________________________________^ inputs.directory may expand into attacker-controllable code
   |
   = note: audit confidence → Low

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/fuzz-go.yml:92:9
   |
92 |         - name: Fuzz
   |           ^^^^^^^^^^ this step
93 | /         run: |
94 | |           # Change directory to the package first, since go test doesn't
...  |
97 | |           cd "${{ matrix.package }}"
98 | |           go test -fuzz="${{ matrix.function }}\$" -run="${{ matrix.function }}\$" -fuzztime="${{ inputs.fuzz-time }}" .
   | |________________________________________________________________________________________________________________________^ inputs.fuzz-time may expand into attacker-controllable code
   |
   = note: audit confidence → Low

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/helm-release.yml:28:9
   |
28 |         - name: List changed charts
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^ this step
29 |           id: list-changed
30 | /         run: |
31 | |           cd source
...  |
58 | |             echo "changed=false" >> $GITHUB_OUTPUT
59 | |           fi
   | |____________^ github.ref_name may expand into attacker-controllable code
   |
   = note: audit confidence → High

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/helm-release.yml:28:9
   |
28 |         - name: List changed charts
   |           ^^^^^^^^^^^^^^^^^^^^^^^^^ this step
29 |           id: list-changed
30 | /         run: |
31 | |           cd source
...  |
58 | |             echo "changed=false" >> $GITHUB_OUTPUT
59 | |           fi
   | |____________^ github.ref_name may expand into attacker-controllable code
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/helm-release.yml:26:9
   |
26 |         uses: helm/[email protected]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
   --> ./.github/workflows/helm-release.yml:102:9
    |
102 |         uses: azure/setup-helm@v4
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
    |
    = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
   --> ./.github/workflows/helm-release.yml:145:9
    |
145 |         uses: softprops/action-gh-release@v2
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
    |
    = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/helm-test.yml:28:9
   |
28 |         uses: azure/setup-helm@v4
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/helm-test.yml:49:9
   |
49 |         uses: azure/setup-helm@v4
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/helm-test.yml:60:9
   |
60 |         uses: helm/[email protected]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/helm-test.yml:74:9
   |
74 |         uses: helm/[email protected]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[excessive-permissions]: overly broad permissions
 --> ./.github/workflows/publish-alloy-devel.yml:9:3
  |
9 |   id-token: write
  |   ^^^^^^^^^^^^^^^ id-token: write is overly broad at the workflow level
  |
  = note: audit confidence → High

error[template-injection]: code injection via template expansion
  --> ./.github/workflows/publish-alloy.yaml:48:7
   |
48 |       - run: |
   |  _______^
49 | |        & "C:/Program Files/git/bin/bash.exe" -c 'WINDOWS_VERSION=${{matrix.os}} ALLOY_GO_VERSION=${{steps.get_go_version.outputs.alloy_go_version}} ./tools/ci/docker-containers-windows ${{ inputs.img-name }}'
   | |                                                                                                                                                                                                                 ^
   | |_________________________________________________________________________________________________________________________________________________________________________________________________________________|
   |                                                                                                                                                                                                                   this step
   |                                                                                                                                                                                                                   inputs.img-name may expand into attacker-controllable code
   |
   = note: audit confidence → Low

error[unpinned-uses]: unpinned action reference
 --> ./.github/workflows/scripts.yml:9:7
  |
9 |     - uses: azohra/shell-linter@latest
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
  |
  = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/test_pr.yml:17:7
   |
17 |       uses: golangci/golangci-lint-action@v6
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/test_pr.yml:21:7
   |
21 |       uses: golangci/golangci-lint-action@v6
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

error[unpinned-uses]: unpinned action reference
  --> ./.github/workflows/trivy.yml:38:9
   |
38 |         uses: github/codeql-action/upload-sarif@v3
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)
   |
   = note: audit confidence → High

160 findings (96 ignored, 36 suppressed): 0 unknown, 0 informational, 0 low, 0 medium, 28 high