Skip to content

General updates and corrections to the Alloy Component docs part 2 #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented May 22, 2025

This PR is part of a series of PRs that aim to catch a few minor typos and errors that have crept into the docs through all the recent refactoring and updates.

Most corrections are minor:

  • fix occasional typos
  • sort out some table formatting that was missed or has shown up from other unrelated edits
  • remove some extra spaces at the start/end of lines

This PR also includes validating the args etc. against the source files (as a double check to make sure everything matches). Some corrections include correcting data types to match what's documented and removing quotes from default values on int and duration types.

Copy link
Contributor

github-actions bot commented May 22, 2025

@clayton-cornell clayton-cornell marked this pull request as ready for review May 22, 2025 23:03
@clayton-cornell clayton-cornell requested a review from a team May 22, 2025 23:04
@clayton-cornell clayton-cornell marked this pull request as draft May 23, 2025 23:03
| Name | Type | Description | Default | Required |
| ---------------- | ---------------- | -------------------------------------------------------------- | -------- | -------- |
| `forward_to` | `list(receiver)` | Where to forward log entries after relabeling. | | yes |
| `max_cache_size` | `int` | The maximum number of elements to hold in the relabeling cache | `10,000` | no |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this value be with a comma or just 10000?

| `allowlist` | `map(string)` | List of regular expressions to allowlist matching secrets. | `{}` | no |
| `gitleaks_config` | `string` | Path to the custom `gitleaks.toml` file. | Embedded Gitleaks file | no |
| `include_generic` | `bool` | Include the generic API key rule. | `false` | no |
| `origin_label` | `string` | Loki label to use for the `secrets_redacted_by_origin` metric. | `""` | no |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing arg

@clayton-cornell clayton-cornell marked this pull request as ready for review May 26, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant