Retry initializing informers to allow for network instability on node restart #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
approved these changes
Jun 10, 2025
| var informer cache.Informer | ||
| var err error | ||
| i := 0 | ||
| for { |
There was a problem hiding this comment.
Nit: I'd prefer an indexed for loop here instead of if i==2.
There was a problem hiding this comment.
Implemented Kalle's recommendation to use the dskit backoff package instead.
kalleep
reviewed
Jun 10, 2025
| var informer cache.Informer | ||
| var err error | ||
| i := 0 | ||
| for { |
There was a problem hiding this comment.
Nit: we could try to use github.com/grafana/dskit/backoff for retires like we do in a lot of other places
kalleep
approved these changes
Jun 10, 2025
ptodev
pushed a commit
that referenced
this pull request
Jun 25, 2025
… restart (#3688) * Retry initializing informers to allow for network instability on node restart * use dskit backoff * return error on failure
ptodev
added a commit
that referenced
this pull request
Jun 25, 2025
* Add livedebugging service to validator services list (#3785) * Add livedebugging service to validator list * Update changelog * Accept optional strings as number arguments (#3766) * Accept optional strings * Use "tryCapsuleConvert" instead of "ConvertInto" * fix(ebpf): python typecheck type before reading type name (#3797) * Retry initializing informers to allow for network instability on node restart (#3688) * Retry initializing informers to allow for network instability on node restart * use dskit backoff * return error on failure * Run go mod tidy --------- Co-authored-by: Sam DeHaan <[email protected]> Co-authored-by: Tolya Korniltsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Immediately after a node restart, the Alloy pod is not always able to access the api server due to network initialization. While there may be a more correct way to handle this, to implement a quick solution I've just added a retry mechanism. This solved the problem for me when testing using a local kind cluster, but I would like interested parties to test the fix in their environments as well.
Which issue(s) this PR fixes
Fixes #1853
Notes to the Reviewer
PR Checklist