Skip to content

Use v2 of publishing workflow that checks out HEAD of version branch on tag events #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jdbaldry
Copy link
Contributor

@jdbaldry jdbaldry commented May 29, 2025

This uses a script check in the first step of tag events that switches the checkout to the version branch that the tag refers to: https://github.com/grafana/writers-toolkit/blob/main/publish-technical-documentation-release/determine-release-branch.

Implemented in:

Because the script uses Bash regular expression pattern matching, inputs must use Extended Regular Expression syntax.

jdbaldry added 2 commits May 29, 2025 10:58
…on tag events

This uses a script check in the first step of tag events that switches the checkout to the version branch that the tag refers to: https://github.com/grafana/writers-toolkit/blob/main/publish-technical-documentation-release/determine-release-branch.

Implemented in:

- grafana/writers-toolkit@305f989
- grafana/writers-toolkit@541fb6e

Because the script uses Bash regular expression pattern matching, inputs must use Extended Regular Expression syntax.
Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry changed the title Use v2 of publishing workflow that checks out HEAD of version branch … Use v2 of publishing workflow that checks out HEAD of version branch on tag events May 29, 2025
@@ -25,12 +25,12 @@
with:
fetch-depth: 0
persist-credentials: false
- uses: grafana/writers-toolkit/publish-technical-documentation-release@d83ba5389fb8de1458b12bcc35ad4a4059883029 # publish-technical-documentation-release/v1 # zizmor: ignore[unpinned-uses]
- uses: grafana/writers-toolkit/publish-technical-documentation-release@publish-technical-documentation-release/v2 # zizmor: ignore[unpinned-uses]

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'publish-technical-documentation-release' step
Uses Step
uses 'grafana/writers-toolkit/publish-technical-documentation-release' with ref 'publish-technical-documentation-release/v1', not a pinned commit hash
@jdbaldry jdbaldry requested a review from robbymilo May 29, 2025 10:28
@jdbaldry jdbaldry marked this pull request as ready for review May 29, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants